View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001526 | T99X171.00 SKB Eagle | SW Issue | public | 2022-08-22 16:06 | 2025-04-07 10:00 |
| Reporter | Assigned To | (ALTech) JunGyu Kim | Due Date | ||
| Priority | normal | Severity | s4-minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0001526: TV volume UI is incorrect when CEC/Passthrough is enabled. | ||||
| Description | Hi YK, Our QA find one issue. Please check it with SPTEK. It's related AudioService.java or KeyHandle. I've checked the committed history of AudioService.java. Only SPTEK and Amlogic modified it. This is not a side effect of a recent modification Condition: Pair BA01 RCU Passthrough ON CEC ON Reboot device -> Make sure CEC available. Play AC3 content Press Volume down (STB RCU) while playing PlayMovie "Paid" content => We see the TV volume is increased Press Volume down (STB RCU) while playing Disney+ => We see the TV volume increase by one level and then immediately decrease by one level Please check the attachment (PlayMovie.mp4/Disney.mp4) Logcat Analysis of PlayMovie (logcat.jpg) In Volume up case, the dir=1 means user click Volume up key then we can see the "direction =1" (It's normal) But In Volume down case, the dir= -1 means user click volume down key, but we still see the "direction =1" so it send volume up key to TV by CEC. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
|
2022-08-22 16:06 developer |
|
|
|
|
|
|
Hi YK, Please check the AudioService.png with SPTEK, it looks like the direction is always be set as ADJUSET_RAISE. so if user click volume down (STB RCU), it still send volume up cec key to TV. |
|
|
Hi Jason, Thank you for report this issue. I shared this issue and your analysis to https://jira.skbroadband.com/browse/BTVD-21674 I'll let you know if any update. Thank you. |
|
|
Hi Jason, SPTEK was fix this issue by another jira ticket. The commit is below. frameworks/base Author: scpark97 <scpark97@sptek.co.kr> Date: Thu Aug 25 15:26:32 2022 +0900 [BTVBIPUW-516]BT스피커 연결후 재 부팅시 볼륨소리가 증가하는현상수정 [BTVBIPUW-515]음소거상태에서음향출력외부기기로 변경시 볼륨수정 Change-Id: I16bebf93673d4edcb309a33ae943e60e33e5cdda Please apply this commit and test again. Thank you. |
|
|
Hi JunGyu, I've verified this patch, I have one question. Test steps: 1. enable cec and passthrough 2. play Dolby Digital Content. In previous problematic build => Press volume up/down on STB RCU, we can see the TV UI volume (not STB UI), but the behavior of TV UI volume is wrong. In current build => Press volume up/down on STB RCU, we don't see the TV UI volume, so I can not confirm the behavior of TV UI volume Is this the behavior STPEK want? Thanks, Jason |
|
|
Hi Jason, SPTEK shared test patch but SPTEK's TV does not shown TV UI volume before and after apply this patch. So they could not test patch's affect. Could you please test by apply this patch? Thank you. audioservice_passthroughToTv.patch (3,118 bytes)
diff --git a/services/core/java/com/android/server/audio/AudioService.java b/services/core/java/com/android/server/audio/AudioService.java
index c22f9f7cf72..3676caf80b1 100644
--- a/services/core/java/com/android/server/audio/AudioService.java
+++ b/services/core/java/com/android/server/audio/AudioService.java
@@ -215,11 +215,11 @@ public class AudioService extends IAudioService.Stub
//SPTEK ++ VOLUME_CONTROL
protected static final boolean DEBUG_SKBB = true;
- protected static final boolean DEBUG_TEST = false;
+ protected static final boolean DEBUG_TEST = true;
- protected static final boolean DEBUG_LAST_VOLUME = false;
+ protected static final boolean DEBUG_LAST_VOLUME = true;
- protected static final boolean DEBUG_CTS = false;
+ protected static final boolean DEBUG_CTS = true;
//SPTEK -- VOLUME_CONTROL
/** How long to delay before persisting a change in volume/ringer mode. */
@@ -1950,7 +1950,7 @@ public class AudioService extends IAudioService.Stub
setStreamVolume(streamType,getStreamMaxVolume(streamType),AudioManager.FLAG_SHOW_UI,callingPackage);
sendBroadcastShowToast(SKBB_TOAST_IE_PATH_THROUGH);
}else{
- direction=0;
+ //direction=0;
setStreamVolume(streamType,getStreamMaxVolume(streamType),AudioManager.FLAG_SHOW_UI,callingPackage);
sendBroadcastShowToast(SKBB_TOAST_IE_PATH_THROUGH);
}
@@ -2024,9 +2024,11 @@ public class AudioService extends IAudioService.Stub
streamType = getActiveStreamType(streamType); // fixed for cts volume test
//SPTEK -- VOLUME_CONTROL
+ if (DEBUG_DEVICES) Log.d(TAG,"###adjustStreamVolume direction = " + direction);
ensureValidDirection(direction);
ensureValidStreamType(streamType);
+ if (DEBUG_DEVICES) Log.d(TAG,"###adjustStreamVolume direction = " + direction);
boolean isMuteAdjust = isMuteAdjust(direction);
if (isMuteAdjust && !isStreamAffectedByMute(streamType)) {
@@ -2069,10 +2071,12 @@ public class AudioService extends IAudioService.Stub
+ "(device & AudioSystem.DEVICE_OUT_ALL_A2DP): " + (device & AudioSystem.DEVICE_OUT_ALL_A2DP));
if( mIsDDS && streamType == AudioSystem.STREAM_MUSIC && ((flags & AudioManager.FLAG_FROM_KEY)!=0) && ((device & AudioSystem.DEVICE_OUT_ALL_A2DP) == 0)){
if(direction==0) return;
- direction = AudioManager.ADJUST_RAISE;
+ //direction = AudioManager.ADJUST_RAISE;
sendBroadcastShowToast(SKBB_TOAST_IE_PATH_THROUGH);
+ if (DEBUG_DEVICES) Log.d(TAG,"adjustStreamVolume11111 direction = " + direction);
+
}
- if (DEBUG_DEVICES) Log.d(TAG,"adjustStreamVolume direction = " + direction);
+ if (DEBUG_DEVICES) Log.d(TAG,"###adjustStreamVolume direction = " + direction);
//SPTEK -- VOLUME_CONTROL
//SPTEK ++ VOLUME_CONTROL : add log
|
|
|
Hi JunGyu, Before Applying the following patch (version 15.534.28) [BTVBIPUW-516]BT스피커 연결후 재 부팅시 볼륨소리가 증가하는현상수정 [BTVBIPUW-515]음소거상태에서음향출력외부기기로 변경시 볼륨수정 Does SPTEK reboot device after enabling Passthrough/CEC? Test Condition: (15.534.28) Pair BA01 RCU Passthrough ON CEC ON Reboot device -> Make sure CEC available. Play AC3 content You can see the TV Volume UI, but the behavior is incorrect. Can you also reproduce it on your side? Thanks, Jason |
|
|
Hi Jason, I have tested as you mentioned sequence(Reboot device after Enable CEC), TV Volume UI does not appear. And TV's volume is not changed when press RCU volume button. I tested in SAMSUNG and LG TV. Thank you. |
|
|
Hi JunGyu, Did you test it with Dolby Audio content? If you don't have PlayMovie paid content, I think you can verify it with Disney+. Thanks, Jason |
|
|
Hi Jason, I tested with Play movie (Doctor Strange in the Multiverse of Madness - Trailer) and Disney+ (Doctor Strange in the Multiverse of Madness). All contents are Dolby audio content. The result is same. TV volume UI does not appear. Thank you. |
|
|
Hi JunGyu, Hi JunGyu Please check the attachment issueWithSonyTV-20220906.mp4 At first frame: confirm the version is 15.534.28 At time 48s: Play Doctor Strange in the Multiverse of Madness => you can see the info page, it shows "5.1" icon, it's Dolby audio At time 59s: Our QA press volume up on STB RCU, you can see the TV Volume UI is increased, and the top of screen also shows the toast. At time 1min03s: Our QA press volume down on STB RCU, you can see the TV Volume UI is still increased, and the top of screen also shows the toast. |
|
|
Hi Jason, Is issueWithSonyTV-20220906.mp4 the result after applying the patch(audioservice_passthroughToTv.patch)? Thank you. |
|
|
Hi JunGyu, No, the video clip (issueWithSonyTV-20220906.mp4) is tested with 15.534.28. Test1: 15.534.28 => The behavior is weird. Test2: 15.534.28 + following patch => The TV UI volume is gone. it looks good. but I am not sure if this is the expected result. so I ask you on comment https://mantis.cnsbg.foxconn.com/vaas/view.php?id=1526#c10754 [BTVBIPUW-516]BT스피커 연결후 재 부팅시 볼륨소리가 증가하는현상수정 [BTVBIPUW-515]음소거상태에서음향출력외부기기로 변경시 볼륨수정 Test3: 15.534.28 + following patch + audioservice_passthroughToTv.patch (not tested yet) [BTVBIPUW-516]BT스피커 연결후 재 부팅시 볼륨소리가 증가하는현상수정 [BTVBIPUW-515]음소거상태에서음향출력외부기기로 변경시 볼륨수정 If the result of test2 is the excepted result, I think we don't need to test Test3 (including audioservice_passthroughToTv.patch) Thanks, Jason |
|
|
Hi Jason, Sorry for the confusion. 1. The symptom that the TV volume UI does not appear due to the patch below is incorrect. [BTVBIPUW-516]BT스피커 연결후 재 부팅시 볼륨소리가 증가하는현상수정 [BTVBIPUW-515]음소거상태에서음향출력외부기기로 변경시 볼륨수정 2. SPTEK delivered a patch for the fix, but the symptoms are not reproduced on TVs owned by SPTEK and ALT. 3. In conclusion, please test after applying the modifications as follows. [BTVBIPUW-516]BT스피커 연결후 재 부팅시 볼륨소리가 증가하는현상수정 [BTVBIPUW-515]음소거상태에서음향출력외부기기로 변경시 볼륨수정 audioservice_passthroughToTv.patch Thank you. |
|
|
Hi JunGyu, After applying the following patches, [BTVBIPUW-516]BT스피커 연결후 재 부팅시 볼륨소리가 증가하는현상수정 [BTVBIPUW-515]음소거상태에서음향출력외부기기로 변경시 볼륨수정 audioservice_passthroughToTv.patch For PlayMovie => Looks good to me. (PlayMovie_20220912.mp4) For Disney+ => Please refer DisneyPlus_20220912.mp4. When a volume up/down button is pressed, the TV Volume UI will be increased/decreased 2 levels You can compare DisneyPlus_20220912.mp4 with PlayMovie_20220912.mp4. |
|
|
Hi Jason, I shared that your comment to STPEK. In conclusion, the behavior is correct that TV volume UI does not appear. Because when passthrough is enabled, SKB's concept is that the volume control does not needed. And If user want to control TV's volume, user can control with RCU's right volume button. Additionally, SPTEK reviewed INTEK Smart 3 code, CEC related code does not exist. Thank you. |
|
|
Hi JunGyu, I agree with SKB's concept. I've also checked this question with Jerry. He said this function is implemented by Amlogic for Netflix certification. (cec should work in passthrough mode) You can check the history of AudioService.java (AudioService.java.png) As you know, the Smart3 doesn't support Netflix currently. I think SPTEK can refer this patch, and make our Sony TV to meet SKB's requirement. Thanks, Jason |
|
|
Hi Jason, Thanks for the check of history. I shared the history with SPTEK. When the Smart3 support Netflix, SPTEK will discuss this function with SKB. Thanks. |
|
|
no activity for this issue |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-08-22 16:06 |
|
New Issue | |
| 2022-08-22 16:06 |
|
Status | new => assigned |
| 2022-08-22 16:06 |
|
Assigned To | => (ALTech) Younkwang Jung |
| 2022-08-22 16:06 |
|
File Added: Disney.mp4 | |
| 2022-08-22 16:06 |
|
File Added: PlayMovie.mp4 | |
| 2022-08-22 16:07 |
|
Note Added: 0010681 | |
| 2022-08-22 16:07 |
|
File Added: logcat.jpg | |
| 2022-08-22 16:14 |
|
Note Added: 0010682 | |
| 2022-08-22 16:14 |
|
File Added: AudioService.png | |
| 2022-08-22 16:54 | (ALTech) JunGyu Kim | Note Added: 0010684 | |
| 2022-08-30 12:22 | (ALTech) JunGyu Kim | Note Added: 0010747 | |
| 2022-08-31 10:28 |
|
Note Added: 0010754 | |
| 2022-08-31 10:28 |
|
Assigned To | (ALTech) Younkwang Jung => (ALTech) JunGyu Kim |
| 2022-09-05 09:18 | (ALTech) JunGyu Kim | Note Added: 0010777 | |
| 2022-09-05 09:18 | (ALTech) JunGyu Kim | File Added: audioservice_passthroughToTv.patch | |
| 2022-09-05 11:28 |
|
Note Added: 0010783 | |
| 2022-09-05 12:31 | (ALTech) JunGyu Kim | Note Added: 0010784 | |
| 2022-09-05 14:53 |
|
Note Added: 0010787 | |
| 2022-09-06 13:32 | (ALTech) JunGyu Kim | Note Added: 0010805 | |
| 2022-09-06 18:10 |
|
Note Added: 0010807 | |
| 2022-09-06 18:10 |
|
File Added: issueWithSonyTV-20220906.mp4 | |
| 2022-09-07 08:49 | (ALTech) JunGyu Kim | Note Added: 0010809 | |
| 2022-09-07 09:40 |
|
Note Added: 0010810 | |
| 2022-09-07 10:49 | (ALTech) JunGyu Kim | Note Added: 0010813 | |
| 2022-09-12 14:40 |
|
Note Added: 0010841 | |
| 2022-09-12 14:40 |
|
File Added: PlayMovie_20220912.mp4 | |
| 2022-09-12 14:40 |
|
File Added: DisneyPlus_20220912.mp4 | |
| 2022-09-15 08:39 | (ALTech) JunGyu Kim | Note Added: 0010858 | |
| 2022-09-15 09:39 |
|
Note Added: 0010863 | |
| 2022-09-15 09:39 |
|
File Added: AudioService.java.jpg | |
| 2022-09-15 10:10 | (ALTech) JunGyu Kim | Note Added: 0010867 | |
| 2025-04-07 10:00 | (SW) Kerwin Chen | Status | assigned => closed |
| 2025-04-07 10:00 | (SW) Kerwin Chen | Resolution | open => fixed |
| 2025-04-07 10:00 | (SW) Kerwin Chen | Note Added: 0017416 |

